Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compute_unit_per_broker and storage_unit_per_bookie #93

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maxsxu
Copy link
Member

@maxsxu maxsxu commented Dec 19, 2024

Motivation

The compute_unit and storage_unit are actually "per broker" or "per bookie" rather than "total". so rename to avoid confuse.

Modifications

  • Add compute_unit_per_broker and storage_unit_per_bookie

  • Deprecate compute_unit and storage_unit

  • Update docs

Verifications

Will show following warnings:

╷
│ Warning: Argument is deprecated
│ 
│   with streamnative_pulsar_cluster.test-cluster-2,
│   on main.tf line 23, in resource "streamnative_pulsar_cluster" "test":
│   23:   compute_unit     = 0.3
│ 
│ Deprecated. Please use compute_unit_per_broker instead.
│ 
│ (and 3 more similar warnings elsewhere)

@maxsxu maxsxu requested review from sijie and tuteng December 19, 2024 18:49
@maxsxu maxsxu self-assigned this Dec 19, 2024
@maxsxu maxsxu requested a review from a team as a code owner December 19, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant