Sdc 11402 #24
Open
Sdc 11402 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling latest code from Streamsets:master
…nfiguration test_directory_origin_configuration_extra_column_prefix
dimaspivak
requested changes
May 17, 2019
| pass | ||
| data_format, allow_extra_columns, header_line, file_writer, shell_executor): | ||
| """ | ||
| In this test case 3 lines are taken with delimited of ',' of 3 columns(header). |
There was a problem hiding this comment.
Follow docstring style convention used in rest of file, please (i.e. first line of text is immediately after """ without line break)
| def test_directory_origin_configuration_extra_column_prefix(sdc_builder, sdc_executor, | ||
| data_format, allow_extra_columns, header_line): | ||
| pass | ||
| data_format, allow_extra_columns, header_line, file_writer, shell_executor): |
There was a problem hiding this comment.
As described in other review, follow spacing convention of rest of file.
| pipeline_builder = sdc_builder.get_pipeline_builder() | ||
| directory = pipeline_builder.add_stage('Directory') | ||
| directory.set_attributes(extra_column_prefix="_extra_", | ||
| allow_extra_columns=allow_extra_columns, |
There was a problem hiding this comment.
Looks like a space is needed to line this up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.