Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdc 11390 #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sdc 11390 #28

wants to merge 3 commits into from

Conversation

manishztal
Copy link
Contributor

No description provided.

anubandhan and others added 3 commits April 24, 2019 16:19
Pulling latest code from Streamsets:master
Latest changes from Stremsets master.
…uration

* Used TC test_directory_origin_configuration_batch_size_in_recs to check functionality
Copy link
Member

@dimaspivak dimaspivak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a test of this configuration would be more of a negative test (e.g. have a nested folder structure /tmp/1 and /tmp/2 and verify that setting /tmp/1 only parses the things from the first folder? Just worrying that we don't gain much from running some other test as part of this (and it definitely doesn't help in terms of the readability).

@manishztal
Copy link
Contributor Author

manishztal commented Jun 16, 2019

/tmp already have folders inside it (other than random word folder we create) e.g. /tmp/xDfbldg. There are other folder under /tmp and setting up files_directory to "/tmp/xDfbldg" parses that folder only. Nothing else. I am calling other test from this test as we are already testing this configuration parameter. If we don't want to call one test from other we can just leave this test as empty leaving comment that this configuration is tested in other test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants