Add integration tests for Consumer, Producer and Streams #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimaison
force-pushed
the
integration-tests
branch
2 times, most recently
from
e7be3d7 to
5aa8ac9
Compare
mimaison
changed the title
Signed-off-by: Mickael Maison <[email protected]>
mimaison
force-pushed
the
integration-tests
branch
from
5aa8ac9 to
ac7da0b
Compare
see-quick
approved these changes
Dec 2, 2024
| public class TestUtils { | ||
|
|
||
| private static final String VERSION = "1.0.0-SNAPSHOT"; | ||
| private static final String CLIENTS_IMAGE = "quay.io/strimzi-test-clients/test-clients:latest-kafka-3.9.0"; |
There was a problem hiding this comment.
Maybe extract the Kafka version here to separate variable?
| public void setUp() throws Exception { | ||
| broker = new StrimziKafkaContainer() | ||
| .withKraft() | ||
| .withNetworkAliases("kafka"); |
There was a problem hiding this comment.
Extract this network kafka alias into a TestUtils so it can be reused across all integration tests.
Signed-off-by: Mickael Maison <[email protected]>
|
@mimaison I don't see the tests running in azure. Is that intended from some reason? |
|
I can see the new tests (
Am I missing something? |
ah sorry, I forgot that ctrl + f doesn't work within azp log. 🤦 |
Frawless
approved these changes
Dec 6, 2024
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding integration tests for running the metrics reporter in consumers, producer and streams applications.