-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for message timestamp #915
Conversation
@antonio-pedro99 I haven't reviewed the PR yes but I see this doc build failure here you should address ... ERROR: Uncommitted changes in documentation:
M documentation/book/api/definitions.adoc
Run the following to add up-to-date resources:
make docu_api \
&& git add documentation/book/ \
&& git commit -s -m 'Update generated documentation'
make: *** [Makefile:67: docu_check] Error 1 after that I will start my review. Thanks! |
@ppatierno sorry for being late. Any clue about this error? [ERROR] Failed to execute goal io.github.swagger2markup:swagger2markup-maven-plugin:1.3.7:convertSwagger2markup (generate-apidoc) on project kafka-bridge: Failed to execute goal 'convertSwagger2markup': Error creating extended parser class: Could not determine whether class 'org.pegdown.Parser$$parboiled' has already been loaded: Unable to make protected final java.lang.Class java.lang.ClassLoader.findLoadedClass(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @358ab600 -> [Help 1] I have been trying to fix, but could not figure it out. |
No idea :-( |
Could it be a wrong Java version or something? |
@antonio-pedro99 we are going to plan a release. Are you still working to fix this on your side? or should we leave it out of 0.30.0? |
Yeah, I am going to finish it soon. |
I guess so |
@ppatierno, we had a similar issue here #858 (comment) I guess there is something wrong with my setup, I will double-check the contribution documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pushed the doc changes as done last time and left some minor comments.
src/test/java/io/strimzi/kafka/bridge/clients/BasicKafkaClient.java
Outdated
Show resolved
Hide resolved
src/test/java/io/strimzi/kafka/bridge/clients/BasicKafkaClient.java
Outdated
Show resolved
Hide resolved
src/test/java/io/strimzi/kafka/bridge/clients/BasicKafkaClient.java
Outdated
Show resolved
Hide resolved
src/test/java/io/strimzi/kafka/bridge/clients/BasicKafkaClient.java
Outdated
Show resolved
Hide resolved
src/test/java/io/strimzi/kafka/bridge/clients/BasicKafkaClient.java
Outdated
Show resolved
Hide resolved
src/test/java/io/strimzi/kafka/bridge/clients/BasicKafkaClient.java
Outdated
Show resolved
Hide resolved
src/test/java/io/strimzi/kafka/bridge/clients/BasicKafkaClient.java
Outdated
Show resolved
Hide resolved
@antonio-pedro99 we also need the feature to be listed in the CHANGELOG. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like something definitely worth having it in the CHANGELOG. LGTM otherwise. Thanks for the PR
Thanks a lot for this. |
31c82be
to
04e5b1c
Compare
Signed-off-by: Antonio Pedro <[email protected]>
Signed-off-by: Antonio Pedro <[email protected]>
Signed-off-by: Antonio Pedro <[email protected]>
Signed-off-by: Paolo Patierno <[email protected]> Signed-off-by: Antonio Pedro <[email protected]>
04e5b1c
to
3c5845d
Compare
Signed-off-by: Antonio Pedro <[email protected]>
Signed-off-by: Antonio Pedro <[email protected]>
Signed-off-by: Antonio Pedro <[email protected]>
Signed-off-by: Paolo Patierno <[email protected]> Signed-off-by: Antonio Pedro <[email protected]>
Signed-off-by: Antonio Pedro <[email protected]>
6744a53
to
1c5ef6e
Compare
Signed-off-by: Antonio Pedro <[email protected]>
Signed-off-by: Antonio Pedro <[email protected]>
Signed-off-by: Antonio Pedro <[email protected]>
Signed-off-by: Paolo Patierno <[email protected]>
Signed-off-by: Paolo Patierno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Antonio. I reworded the CHANGELOG addition and resolved a conflict. Now ready to be merged! LGTM ;-)
Description:
This PR fixes #912. It introduces enhancements to the Kafka bridge to support more flexible message timestamp handling by allowing producers to specify timestamps explicitly in
ProducerRecord
objects. Currently, the Kafka bridge does not fully utilize thetimestamp
parameter in theProducerRecord
constructors, leading to using the CreateTime message timestamp type every time we produce a message. On the other hand, theConsumerRecord
has also been updated with the timestamp parameter.Changes:
timestamp
parameter inProducerRecord
objects sent to Kafka topics via the bridge.ConsumerRecord
timestamp on the request's response. E.gCreateTime
orLogAppendTime
).Testing:
timestamp
inProducerRecord
.BasicKafkaClient
to changeConsumerIT
with the required tests.