Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed controller logging in ZK mode #11156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ppatierno
Copy link
Member

Trivial PR to remove the Kafka controller (default) logging for the ZooKeeper mode which is now not supported anymore.

@ppatierno ppatierno added this to the 0.46.0 milestone Feb 18, 2025
@ppatierno ppatierno requested a review from a team February 18, 2025 14:38
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would continue to stick with Kafka's defaults and not diverge from them.

@ppatierno
Copy link
Member Author

ppatierno commented Feb 18, 2025

I would continue to stick with Kafka's defaults and not diverge from them.

I am not diverging I am just removing the logger that was used when ZK mode was in place from a broker controller perspective. With KRaft mode that logger doesn't work and the log4j.logger.org.apache.kafka.controller=INFO is used instead.

@ppatierno ppatierno force-pushed the remove-zk-mode-controller-logging branch from d873db4 to 94ab2c7 Compare February 19, 2025 11:20
@katheris
Copy link
Contributor

Presumably this change is for when we are KRaft mode only right? Will Kafka have also moved to using log4j2 in that release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants