Fix build warnings and errors in Visual Studio 2022 #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh
reviewed
Dec 19, 2023
| @@ -674,7 +674,7 @@ struct heif_error svt_encode_image(void* encoder_raw, const struct heif_image* i | |||
| svt_config.logical_processors = encoder->threads; | |||
|
|
|||
| // disable 2-pass | |||
| svt_config.rc_stats_buffer = (SvtAv1FixedBuf) {nullptr, 0}; | |||
| svt_config.rc_stats_buffer = {nullptr, 0}; | |||
There was a problem hiding this comment.
@fishmonger42 This part already got applied (see #1059) and is probably the cause of the merge conflicts. Possibly you just need to drop it.
|
Thanks. I've fixed the merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the implementation of getopt_internal match the declaration
Fix warning about the unsafe use of int as bool
Remove unnecessary cast (SvtAv1FixedBuf) causing compiler error