Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exif: fix integer overflow in position check #1050

Closed
wants to merge 1 commit into from
Closed

exif: fix integer overflow in position check #1050

wants to merge 1 commit into from

Conversation

bradh
Copy link
Contributor

@bradh bradh commented Dec 1, 2023

Resolves #1043

@bradh bradh mentioned this pull request Dec 1, 2023
Closed
@farindk
Copy link
Contributor

farindk commented Dec 14, 2023

Thanks, @bradh . I've fixed this is a slightly different way: 730a9d8
In the EXIF specs, they don't tell whether all offsets and counts should be signed or unsigned. But since it is very probable that they actually mean unsigned, I've changed all data types and added a check for the whole IFD table.

@farindk farindk closed this Dec 14, 2023
@bradh bradh deleted the issue1043_merge_master branch December 14, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SEGV libheif/libheif/exif.cc:55 in read16
2 participants
@bradh @farindk