openjpeg: add support for setting lossless mode #1071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farindk
pushed a commit
that referenced
this pull request
Jan 16, 2024
farindk
pushed a commit
that referenced
this pull request
Jan 16, 2024
|
Thanks. I've also split this into two commits. |
bradh
added a commit
to bradh/libheif
that referenced
this pull request
Jan 16, 2024
This was in strukturag#1071, but appears to have been dropped during the split of that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lossless (reversible) is the default in OpenJPEG, and previously we silently ignored setting that on or off.
This moves the compression parameters into the encoder context, and allows setting it.
In my tests, reversible was actually smaller (and matched the pre-PR size). Possibly that is just a function of the test image input though.