Fix filename in fuzzing corpus so it gets parsed during regression testing #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farindk
reviewed
Jul 4, 2024
| heif_suberror_Security_limit_exceeded, | ||
| sstr.str()); | ||
| } | ||
|
|
||
| image->set_resolution(width, height); |
There was a problem hiding this comment.
Simpler fix would be to set the argument type for set_resolution() to uint32_t. It is uint32_t internally anyway.
There was a problem hiding this comment.
Ok, but it's returned as int in the getters and I didn't want to introduce any potential other errors by changing the type in various places.
Lines 117 to 119 in e42b01f
Also it's returned as int in the public API:
libheif/libheif/api/libheif/heif.cc
Line 804 in e42b01f
libheif/libheif/api/libheif/heif.cc
Line 815 in e42b01f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1204