Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files from tests to fuzzing corpus to improve coverage. #1258

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

fancycode
Copy link
Member

No description provided.

@fancycode
Copy link
Member Author

@farindk not sure if the bpp check is fine or if values < 8 should be supported here.

@farindk
Copy link
Contributor

farindk commented Aug 2, 2024

The problem is that we never considered <8 bits before and thus 8 bit color conversions use hard-coded constants at all kind of places. Simply replacing (bitdepth != 8) with (bitdepth <= 8) will lead to wrong conversions, but bitdepth != 8 will lead to misclassifying this as HDR. Both are wrong and we should instead disable the color-conversions for bitdepth < 8 until this is supported.
I'll merge this and add the required tests.

@farindk farindk merged commit ce924c9 into master Aug 2, 2024
36 of 37 checks passed
farindk added a commit that referenced this pull request Aug 2, 2024
farindk added a commit that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants