Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffmpeg plugin] Fix leak during failure #1289

Closed
wants to merge 1 commit into from

Conversation

roticv
Copy link
Contributor

@roticv roticv commented Aug 27, 2024

When decoding "fails" in ffmpeg decoder, it is possible that NalMap is not cleaned up properly causing a leak.

When decoding "fails" in ffmpeg decoder, it is possible that NalMap is not
cleaned up properly causing a leak.
@farindk
Copy link
Contributor

farindk commented Aug 30, 2024

Thank you. I have fixed this in a different way by using a std::unique_ptr. That makes sure that the memory is freed in any edge case and also simplifies existing code.

@farindk farindk closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants