Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TIFF decoding #1301

Closed
wants to merge 13 commits into from
Closed

Conversation

bradh
Copy link
Contributor

@bradh bradh commented Sep 8, 2024

This is an initial rework of the TIFF decoder support, in preparation for reading other data types and higher bit depths.

Because this code is starting to get tricky, I really wanted unit tests. Also, this is looking like code that would be useful in general - not just for the specific examples. In support of that, I've made it into a library - notionally libheifio, but I'm flexible on the name. It doesn't get provided as API yet. It has error handling, not just exit() calls.

Resolves #1300

Also resolves a failure reading RGBA planar files.

./examples/heif-enc ~/rgba_planar.tif out.heif
munmap_chunk(): invalid pointer
Aborted (core dumped)

@bradh bradh marked this pull request as draft September 8, 2024 04:57
@bradh
Copy link
Contributor Author

bradh commented Sep 15, 2024

It looks like the library may not be static. That needs to be fixed.

@farindk
Copy link
Contributor

farindk commented Sep 17, 2024

Is this still a draft or ready for merging?

@bradh bradh marked this pull request as ready for review September 17, 2024 22:49
@bradh
Copy link
Contributor Author

bradh commented Sep 17, 2024

@farindk if you are OK with the design then I am OK with this as an initial implementation that we can build onto.

@farindk
Copy link
Contributor

farindk commented Sep 18, 2024

@farindk if you are OK with the design then I am OK with this as an initial implementation that we can build onto.

Yes, I can merge this and then I would reorganize the files a bit: move the heifio directory next to the libheif directory and move the tests into a subdirectory of the top-level tests directory. Hope that is ok.

@farindk
Copy link
Contributor

farindk commented Sep 18, 2024

Merged with rebase.

@farindk farindk closed this Sep 18, 2024
@bradh bradh deleted the tiff_decode_refactor branch September 18, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reading TIFF mono files fails
2 participants