Graphql isOngoing, isPast and isFuture Time aware fix #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem when trying to filter an entry using the isOngoing, isPast and isFuture filters on an graphql query.
It happens that this filters only check for the date of the entry, not having into account the actual time (hs/min/secs).
This fix will allow to perform a time aware query (including the time, not just the date) so we can pick the entries more accurately.
I have tested to be working on my branch,
Feedback is welcome. (if you can merge this quick it will be appreciated!)
Thanks!