added php 8.x compatibility

studioraz · Jul 1, 2024 · fcab705 · fcab705
1 parent 3652bd0
commit fcab705
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/composer.json b/composer.json
@@ -3,14 +3,9 @@
     "description": "Magento 2 module to automatically generate critical css with the addyosmani/critical npm package",
     "type": "magento2-module",
     "prefer-stable": true,
-    "version": "2.0.1",
+    "version": "2.1.0",
     "keywords": [
     ],
-    "require": {
-        "magento/framework": "^102.0|^103.0",
-        "php": ">=7.1.0"
-    },
-    "type": "magento2-module",
     "license": [
         "MIT"
     ],

diff --git a/src/Service/CriticalCss.php b/src/Service/CriticalCss.php
@@ -22,8 +22,8 @@ public function __construct(ProcessFactory $processFactory)
     public function createCriticalCssProcess(
         string $url,
         array $dimensions,
-        string $criticalBinary = 'critical',
         array $forceIncludeCssSelectors,
+        string $criticalBinary = 'critical',
         ?string $username = null,
         ?string $password = null
     ) {

diff --git a/src/Service/ProcessManager.php b/src/Service/ProcessManager.php
@@ -166,8 +166,8 @@ public function createProcessesForProvider(ProviderInterface $provider, StoreInt
             $process = $this->criticalCssService->createCriticalCssProcess(
                 $url,
                 $this->config->getDimensions(),
-                $this->config->getCriticalBinary(),
                 $this->config->getForceIncludeCssSelectors(),
+                $this->config->getCriticalBinary(),
                 $this->config->getUsername(),
                 $this->config->getPassword()
             );