Build: Add JSHint for additional linting

Ref jquery-archivegh-185

.jshintrc

@@ -1,7 +1,21 @@
 {
-	"browser": true,
+	"boss": true,
+	"curly": true,
+	"eqeqeq": true,
+	"eqnull": true,
 	"expr": true,
-	"predef": [ "define" ],
+	"immed": true,
+	"noarg": true,
+	"smarttabs": true,
+	"trailing": true,
 	"undef": true,
-	"unused": true
+	"unused": true,
+
+	"node": true,
+	"esnext": true,
+
+	"globals": {
+		"define": false,
+		"PointerEvent": true
+	}
 }

Gruntfile.js

@@ -1,4 +1,5 @@
 module.exports = function(grunt) {
+  grunt.loadNpmTasks('grunt-contrib-jshint');
   grunt.loadNpmTasks('grunt-contrib-uglify');
   grunt.loadNpmTasks('grunt-git-authors');
   grunt.loadNpmTasks('grunt-jscs');
@@ -62,6 +63,12 @@ module.exports = function(grunt) {
           src: allFiles
         }
       }
+    },
+    jshint: {
+      options: {
+        jshintrc: true
+      },
+      main: allFiles
     }
   });
 
@@ -96,7 +103,7 @@ module.exports = function(grunt) {
   });
 
   grunt.registerTask('default', [ 'lint', 'build', 'uglify' ]);
-  grunt.registerTask('lint', [ 'jscs:lint' ]);
+  grunt.registerTask('lint', [ 'jscs:lint', 'jshint' ]);
   grunt.registerTask('test', [ 'intern:pointerevents' ]);
   grunt.registerTask('ci', [ 'lint', 'build', 'intern:ci' ]);
 };

package.json

@@ -22,6 +22,7 @@
     "chai-spies": "^0.5.1",
     "esperanto": "^0.6.6",
     "grunt": "~0.4.1",
+    "grunt-contrib-jshint": "0.11.2",
     "grunt-contrib-uglify": "^0.4.0",
     "grunt-git-authors": "^3.0.0",
     "grunt-jscs": "1.8.0",

src/.jshintrc

@@ -0,0 +1,21 @@
+{
+	"boss": true,
+	"curly": true,
+	"eqeqeq": true,
+	"eqnull": true,
+	"expr": true,
+	"immed": true,
+	"noarg": true,
+	"smarttabs": true,
+	"trailing": true,
+	"undef": true,
+	"unused": true,
+
+	"browser": true,
+	"esnext": true,
+
+	"globals": {
+		"define": false,
+		"PointerEvent": true
+	}
+}

src/installer.js

@@ -111,11 +111,4 @@ Installer.prototype = {
   }
 };
 
-if (!MO) {
-  Installer.prototype.watchSubtree = function() {
-    console.warn('PointerEventsPolyfill: MutationObservers not found, ' +
-      'touch-action will not be dynamically detected');
-  };
-}
-
 export default Installer;

src/targeting.js

@@ -35,7 +35,7 @@ export default {
   searchRoot: function(inRoot, x, y) {
     if (inRoot) {
       var t = inRoot.elementFromPoint(x, y);
-      var st, sr, os;
+      var st, sr;
 
       // is element a shadow host?
       sr = this.targetingShadow(t);
@@ -68,7 +68,7 @@ export default {
     }
 
     // the owner element is expected to be a Document or ShadowRoot
-    if (s.nodeType != Node.DOCUMENT_NODE && s.nodeType != Node.DOCUMENT_FRAGMENT_NODE) {
+    if (s.nodeType !== Node.DOCUMENT_NODE && s.nodeType !== Node.DOCUMENT_FRAGMENT_NODE) {
       s = document;
     }
     return s;

src/touch-action.js

@@ -23,7 +23,6 @@ var attrib2css = [
 var styles = '';
 
 // only install stylesheet if the browser has touch action support
-var head = document.head;
 var hasNativePE = window.PointerEvent || window.MSPointerEvent;
 
 // only add shadow selectors if shadowdom is supported

src/touch.js

@@ -7,7 +7,6 @@ var captureInfo = dispatcher.captureInfo;
 var findTarget = targeting.findTarget.bind(targeting);
 var allShadows = targeting.allShadows.bind(targeting);
 var pointermap = dispatcher.pointermap;
-var touchMap = Array.prototype.map.call.bind(Array.prototype.map);
 
 // This should be long enough to ignore compat mouse events made by touch
 var DEDUP_TIMEOUT = 2500;
@@ -261,7 +260,7 @@ var touchEvents = {
     }
   },
   overDown: function(inPointer) {
-    var p = pointermap.set(inPointer.pointerId, {
+    pointermap.set(inPointer.pointerId, {
       target: inPointer.target,
       out: inPointer,
       outTarget: inPointer.target

tests/.jshintrc

@@ -0,0 +1,21 @@
+{
+	"boss": true,
+	"curly": true,
+	"eqeqeq": true,
+	"eqnull": true,
+	"expr": true,
+	"immed": true,
+	"noarg": true,
+	"smarttabs": true,
+	"trailing": true,
+	"undef": true,
+	"unused": true,
+
+	"browser": true,
+	"esnext": true,
+
+	"globals": {
+		"define": false,
+		"PointerEvent": true
+	}
+}

tests/unit/capture.js

@@ -125,7 +125,7 @@ define([
         var ids = 0;
         function wait(e) {
           ids += e.pointerId;
-          if (ids == 3) {
+          if (ids === 3) {
             pm.clear();
             dfd.resolve();
           }

tests/unit/pointermap.js

@@ -32,9 +32,6 @@ define([
       }
       expect(p.pointers()).to.equal(1);
     });
-    test('PointerMap .get', function() {
-      var p = new PointerMap();
-    });
     test('PointerMap .pointers', function() {
       var p = new PointerMap();
       expect(p.pointers).to.be.a('function');