Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YAML] Reorganize contexts #3922

Merged
merged 3 commits into from
Feb 17, 2024
Merged

[YAML] Reorganize contexts #3922

merged 3 commits into from
Feb 17, 2024

Conversation

deathaxe
Copy link
Collaborator

This PR...

  1. replaces pop: true by pop: 1 as this is prefered style in version: 2 syntaxes
  2. reorganizes contexts, beginning with comments, followed by blocks and flow contexts
  3. adds various section header contexts to partition syntax definition and improve readability

Notes:

  1. This PR does not change behavior, it is just a maintanance PR to clean up code style.
  2. Context names keep unchanged to not break any 3rd-party packages.

@deathaxe
[YAML] Replace pop: true by pop: 1
a2653d3
@deathaxe
[YAML] Reorganize comment contexts
d7edf8e 
This comment moves comment contexts without changing behavior.
@deathaxe
[YAML] Reorganize block contexts
fa24e8f 
This comment moves block contexts without changing behavior.
@deathaxe deathaxe merged commit 2c829d1 into sublimehq:master Feb 17, 2024
2 checks passed
@deathaxe deathaxe deleted the pr/yaml/reorg-contexts branch February 17, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-hall keith-hall keith-hall approved these changes

@michaelblyons michaelblyons michaelblyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deathaxe @michaelblyons @keith-hall