Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShellScript] reorganize syntax tests #3989

Merged
merged 12 commits into from
Jun 8, 2024
Merged

[ShellScript] reorganize syntax tests #3989

merged 12 commits into from
Jun 8, 2024

Conversation

deathaxe
Copy link
Collaborator

@deathaxe deathaxe commented Jun 6, 2024

This maintenance PR rearranges bash syntax tests by

The main goals are

  1. more easily ensure not to forget tests for certain features especially when cross checking with other/new shell dialects/syntaxes.
  2. separate this pure re-arrangement from upcomming real behavior changing or bugfixing modifications, which modify both syntax definition and syntax tests.

This PR adds some tests (for positional parameters) but does not remove any existing ones.

deathaxe added 12 commits May 14, 2024 20:09
@deathaxe
[ShellScript] Update syntax test section headers
8f09e5b 
This commit updates references in syntax tests to Bash 5.2 docs
as preparation to integrate new shells.

Note: This commit does not change any behavior.
@deathaxe
[ShellScript] Reorganize Shell Parameters tests
6bf9844 
This commit moves shell parameter tests next to shell functions
to align tests by language manual structure.

Note: This commit does not change any behavior.
@deathaxe
[ShellScript] Reorganize Shell Parameter Expansions tests
cea4b1f 
This commit aligns position of positional, special and shell parameter
expansion tests with bash manual structure.

Note: This commit does not change any behavior.
@deathaxe
[ShellScript] Reorganize Bash Pattern Matching tests
19acd2a 
This commit aligns pattern matching tests to align them
with bash manual structure.

Note: This commit does not change any behavior.
@deathaxe
[ShellScript] Reorganize pipeline tests
08529c1
@deathaxe
[ShellScrip] Reorganize redirection tests
a678b58
@deathaxe
[ShellScript] Reorganize loop constructs
cdce8bf
@deathaxe
[ShellScript] Reorganize conditional constructs
594d23e
@deathaxe
[ShellScript] Reorganize heredocs tests
548b8e2
@deathaxe
[ShellScript] Reorganize posix regexp tests
f0d8ebd
@deathaxe
[ShellScript] Add positional arguments tests
9d03d42
@deathaxe
[ShellScript] Reorganize job tests
9b3f58e
@deathaxe deathaxe merged commit fab5cc9 into sublimehq:master Jun 8, 2024
2 checks passed
@deathaxe deathaxe deleted the pr/shellscript/reorganize-tests branch June 8, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-hall keith-hall keith-hall approved these changes

@michaelblyons michaelblyons michaelblyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deathaxe @michaelblyons @keith-hall