[Batch File] Fix comment scope around newlines #3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
reviewed
Jun 17, 2024
mataha
force-pushed
the
fix/batch/empty-line-continuation
branch
4 times, most recently
from
2b35efd to
ccbb91f
Compare
deathaxe
reviewed
Jun 18, 2024
Multiple colons immediately followed by a non-empty line cause said line
to be scoped as a comment:
::: Set some variables
:::
set WSL_UTF8=1
mataha
force-pushed
the
fix/batch/empty-line-continuation
branch
from
ccbb91f to
c0d0d90
Compare
|
This PR has gotten quite unwieldy, so I've limited it to newline continuations only. |
deathaxe
approved these changes
Jun 20, 2024
Well, just by playing trick on my self with a test script and |
deathaxe
added a commit
to deathaxe/sublime-packages
that referenced
this pull request
Jun 20, 2024
This commit fixes "label comment" related patterns, to only scope leading colons `punctuation.definition.comment`. Label comments make use of invalid labels being ignored. A label is invalid, if the first character after leading colon is a "metachar". A label starting with `::` is already an invalid label and thus can be followed by any (meta) char to still be a "valid" comment. The wrong pattern was the real reason for the issue addressed by PR sublimehq#3992.
michaelblyons
approved these changes
Jun 22, 2024
deathaxe
added a commit
to deathaxe/sublime-packages
that referenced
this pull request
Jun 22, 2024
This commit fixes "label comment" related patterns, to only scope leading colons `punctuation.definition.comment`. Label comments make use of invalid labels being ignored. A label is invalid, if the first character after leading colon is a "metachar". A label starting with `::` is already an invalid label and thus can be followed by any (meta) char to still be a "valid" comment. The wrong pattern was the real reason for the issue addressed by PR sublimehq#3992.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple colons immediately followed by a non-empty line cause said line
to be scoped as a comment: