Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto-detect virtual python environment #183

Merged
merged 8 commits into from
Aug 29, 2022

Conversation

LDAP
Copy link
Contributor

@LDAP LDAP commented Aug 28, 2022

Closes #181
Closes #29

@LDAP
Copy link
Contributor Author

LDAP commented Aug 28, 2022

Currently, this PR is only tested on a Linux based system.

@LDAP LDAP force-pushed the autodetect-venv branch from 63ec4b0 to b0a6d8b Compare August 28, 2022 19:17
@LDAP LDAP force-pushed the autodetect-venv branch 2 times, most recently from e22e216 to 2e6d201 Compare August 28, 2022 19:26
@LDAP LDAP force-pushed the autodetect-venv branch from 2e6d201 to 6054d2f Compare August 28, 2022 19:28
@jfcherng
Copy link
Collaborator

Styling violations are fine. I will fix them after merging. Or, if you want to fix them, just install requirements.txt and run make fix.

@LDAP
Copy link
Contributor Author

LDAP commented Aug 28, 2022

Should be fixed now.

@jfcherng
Copy link
Collaborator

jfcherng commented Aug 28, 2022

I will give it a try on Windows when I am at work tomorrow. 😃

Co-authored-by: Rafał Chłodnicki <[email protected]>
@LDAP LDAP force-pushed the autodetect-venv branch from 61a43bb to 31e7320 Compare August 29, 2022 07:48
@LDAP LDAP requested review from jfcherng and rchl and removed request for jfcherng and rchl August 29, 2022 07:54
@jfcherng jfcherng added the enhancement New feature or request label Aug 29, 2022
@jfcherng jfcherng changed the title Feature: Auto-detect virtual python environment feat: auto-detect virtual python environment Aug 29, 2022
@jfcherng jfcherng merged commit 5f81139 into sublimelsp:master Aug 29, 2022
@jfcherng
Copy link
Collaborator

Thanks for this useful feature. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants