chore(ci): add script and workflow for auto-updating schema #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
commented
Dec 12, 2023
| "strict" | ||
| ], | ||
| "title": "Specifies the default rule set to use for type checking", | ||
| "default": "basic" | ||
| "default": "standard" |
There was a problem hiding this comment.
pyright has recently changed the default value of typeCheckingMode from basic to standard. We have to decide whether we want to follow that in our settings or not. standard triggers some new errors in LSP code base at least.
There was a problem hiding this comment.
I think it would make sense to switch to standard since only then the default values defined in schema should actually match the reality. The issue with the LSP code base was only related to a single diagnostic reportIncompatibleMethodOverride.
jfcherng
approved these changes
Dec 13, 2023
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with ensuring that configuration schema is up to date.
The github workflow in theory should auto-update schema in dependabot PRs but if new pyrightconfig settings are added then it will require updating the LSP part manually.
Totally untested (especially the workflow).