Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session.open_uri_async: Focus view when open file: URI #2079

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Session.open_uri_async: Focus view when open file: URI #2079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions plugin/core/sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1508,6 +1508,11 @@ def _open_file_uri_async(
def handle_continuation(view: Optional[sublime.View]) -> None:
if view and r:
center_selection(view, r)
elif view:
window = view.window()
if window:
window.focus_view(view)
Comment on lines +1511 to +1514
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one place in LSP code that exercises this branch and that's apply_workspace_edit_async. And in that case it makes more sense not to focus all views that are edited IMO.

I feel like there is some refactoring that is needed here to make this all easier to follow and know what to expect. Possibly there should be an explicit argument in all "open file" functions (and there is quite a few) to tell them what to do.

Copy link
Member

@rchl rchl Oct 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess one obstacle to make this more predictable is the fact that there is no way to open a new file and not give it focus...

Copy link
Contributor Author

@LDAP LDAP Oct 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that also means that there is currently no way to always focus the view with Session.open_uri_async, which is a quite common use case in my opinion. (for file uris at least)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe apply_workspace_edit_async shouldn't call Session.open_uri_async at all since that is not what I would expect from the method name. I may attempt a refactoring in that regard once I got some spare time.

Copy link
Member

@rchl rchl Oct 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that also means that there is currently no way to always focus the view with Session.open_uri_async

I agree that there should be but it should likely be an opt-in and through explicit argument.

Maybe apply_workspace_edit_async shouldn't call Session.open_uri_async at all since that is not what I would expect from the method name.

We have to open the file to apply the edit.


sublime.set_timeout_async(lambda: result[1](view))

sublime.set_timeout(lambda: open_file(self.window, uri, flags, group).then(handle_continuation))
Expand Down