-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "folder_exclude_patterns" handling with relative project path #2142
base: main
Are you sure you want to change the base?
Conversation
Needs more work to handle Windows paths correctly. Doesn't match in this case:
|
With latest changes it's still not quite right (slashes are not uniform and the leading
|
I would like to release new version of LSP soon but I think this should be fixed first since it's a new functionality that wasn't released yet. Or alternatively we can revert support for this for now and re-add it later with the fix. I don't think I have patience to deal with file paths right now so might be better to revert for now. |
I thought that I had verified my recent "pseudo-fix" for this, but I have tested again now and I can confirm that it doesn't work. Also I've checked out this branch it still seems to be not fixed (I'm on Windows btw). Not sure if it's necessary to revert the other PR, because it also never worked before, and at least it's probably a step in the right direction (sublime pattern -> glob pattern). You could just not mention it in the release notes instead maybe? |
Handle relative project path.