Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broke Post out and added granular arguments. #6

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Conversation

Pdzly
Copy link
Member

@Pdzly Pdzly commented Dec 13, 2023

No description provided.

@Pdzly Pdzly requested a review from kgilles December 13, 2023 16:05
@Pdzly Pdzly self-assigned this Dec 13, 2023
@Pdzly Pdzly marked this pull request as ready for review December 13, 2023 16:05
@Pdzly
Copy link
Member Author

Pdzly commented Dec 13, 2023

Added Creator with a reason as i think it will be used in the post component lateron

@kgilles
Copy link
Member

kgilles commented Dec 13, 2023

Added Creator with a reason as i think it will be used in the post component lateron

@Pdzly the linter doesn't allow unused variables. I'd recommend we keep it out for now. Another option is that you could update it to show the creator in the Post component if you'd like to add it right away.

Copy link
Member

@kgilles kgilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just make sure the linter ends up happy.

@Pdzly Pdzly enabled auto-merge (squash) December 13, 2023 21:42
@kgilles kgilles self-requested a review December 14, 2023 02:28
@Pdzly Pdzly merged commit 05c1b91 into main Dec 14, 2023
1 check passed
@Pdzly Pdzly deleted the feature/break-out-post branch December 14, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants