fix props passed to select

submittable · Jun 28, 2017 · 06bdffb · 06bdffb
1 parent 689211e
commit 06bdffb
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 56 deletions.
diff --git a/dist/react-select.js b/dist/react-select.js
@@ -287,16 +287,6 @@ var _Select = require('./Select');
 
 var _Select2 = _interopRequireDefault(_Select);
 
-function reduce(obj) {
-	var props = arguments.length <= 1 || arguments[1] === undefined ? {} : arguments[1];
-
-	return Object.keys(obj).reduce(function (props, key) {
-		var value = obj[key];
-		if (value !== undefined) props[key] = value;
-		return props;
-	}, props);
-}
-
 var AsyncCreatable = (0, _createReactClass2['default'])({
 	displayName: 'AsyncCreatableSelect',
 
@@ -315,7 +305,7 @@ var AsyncCreatable = (0, _createReactClass2['default'])({
 					_Select2['default'].Creatable,
 					_this.props,
 					function (creatableProps) {
-						return _react2['default'].createElement(_Select2['default'], _extends({}, reduce(asyncProps, reduce(creatableProps, {})), {
+						return _react2['default'].createElement(_Select2['default'], _extends({}, asyncProps, creatableProps, {
 							onInputChange: function (input) {
 								creatableProps.onInputChange(input);
 								return asyncProps.onInputChange(input);

diff --git a/dist/react-select.min.js b/dist/react-select.min.js
diff --git a/examples/dist/bundle.js b/examples/dist/bundle.js
@@ -284,16 +284,6 @@ var _Select = require('./Select');
 
 var _Select2 = _interopRequireDefault(_Select);
 
-function reduce(obj) {
-	var props = arguments.length <= 1 || arguments[1] === undefined ? {} : arguments[1];
-
-	return Object.keys(obj).reduce(function (props, key) {
-		var value = obj[key];
-		if (value !== undefined) props[key] = value;
-		return props;
-	}, props);
-}
-
 var AsyncCreatable = (0, _createReactClass2['default'])({
 	displayName: 'AsyncCreatableSelect',
 
@@ -312,7 +302,7 @@ var AsyncCreatable = (0, _createReactClass2['default'])({
 					_Select2['default'].Creatable,
 					_this.props,
 					function (creatableProps) {
-						return _react2['default'].createElement(_Select2['default'], _extends({}, reduce(asyncProps, reduce(creatableProps, {})), {
+						return _react2['default'].createElement(_Select2['default'], _extends({}, asyncProps, creatableProps, {
 							onInputChange: function (input) {
 								creatableProps.onInputChange(input);
 								return asyncProps.onInputChange(input);

diff --git a/examples/dist/standalone.js b/examples/dist/standalone.js
@@ -287,16 +287,6 @@ var _Select = require('./Select');
 
 var _Select2 = _interopRequireDefault(_Select);
 
-function reduce(obj) {
-	var props = arguments.length <= 1 || arguments[1] === undefined ? {} : arguments[1];
-
-	return Object.keys(obj).reduce(function (props, key) {
-		var value = obj[key];
-		if (value !== undefined) props[key] = value;
-		return props;
-	}, props);
-}
-
 var AsyncCreatable = (0, _createReactClass2['default'])({
 	displayName: 'AsyncCreatableSelect',
 
@@ -315,7 +305,7 @@ var AsyncCreatable = (0, _createReactClass2['default'])({
 					_Select2['default'].Creatable,
 					_this.props,
 					function (creatableProps) {
-						return _react2['default'].createElement(_Select2['default'], _extends({}, reduce(asyncProps, reduce(creatableProps, {})), {
+						return _react2['default'].createElement(_Select2['default'], _extends({}, asyncProps, creatableProps, {
 							onInputChange: function (input) {
 								creatableProps.onInputChange(input);
 								return asyncProps.onInputChange(input);

diff --git a/lib/AsyncCreatable.js b/lib/AsyncCreatable.js
@@ -16,16 +16,6 @@ var _Select = require('./Select');
 
 var _Select2 = _interopRequireDefault(_Select);
 
-function reduce(obj) {
-	var props = arguments.length <= 1 || arguments[1] === undefined ? {} : arguments[1];
-
-	return Object.keys(obj).reduce(function (props, key) {
-		var value = obj[key];
-		if (value !== undefined) props[key] = value;
-		return props;
-	}, props);
-}
-
 var AsyncCreatable = (0, _createReactClass2['default'])({
 	displayName: 'AsyncCreatableSelect',
 
@@ -44,7 +34,7 @@ var AsyncCreatable = (0, _createReactClass2['default'])({
 					_Select2['default'].Creatable,
 					_this.props,
 					function (creatableProps) {
-						return _react2['default'].createElement(_Select2['default'], _extends({}, reduce(asyncProps, reduce(creatableProps, {})), {
+						return _react2['default'].createElement(_Select2['default'], _extends({}, asyncProps, creatableProps, {
 							onInputChange: function (input) {
 								creatableProps.onInputChange(input);
 								return asyncProps.onInputChange(input);

diff --git a/src/AsyncCreatable.js b/src/AsyncCreatable.js
@@ -2,15 +2,6 @@ import React from 'react';
 import createClass from 'create-react-class';
 import Select from './Select';
 
-function reduce(obj, props = {}){
-  return Object.keys(obj)
-  .reduce((props, key) => {
-    const value = obj[key];
-    if (value !== undefined) props[key] = value;
-    return props;
-  }, props);
-}
-
 const AsyncCreatable = createClass({
 	displayName: 'AsyncCreatableSelect',
 
@@ -25,7 +16,8 @@ const AsyncCreatable = createClass({
 					<Select.Creatable {...this.props}>
 						{(creatableProps) => (
 							<Select
-								{...reduce(asyncProps, reduce(creatableProps, {}))}
+								{...asyncProps}
+								{...creatableProps}
 								onInputChange={(input) => {
 									creatableProps.onInputChange(input);
 									return asyncProps.onInputChange(input);