Add HTTP port rules to HTTPFilter (#185) #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnpridgeon
requested review from
cohix and
a team
and removed request for
cohix
javorszky
suggested changes
Feb 18, 2022
javorszky
approved these changes
Feb 18, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #185
Assumptions:
Valid port numbers are to be enforced by the HTTP library either when constructing the URL or in response to perform a request against an illegal port number
If allow/deny lists are not explicitly set allow all ports for backward compatibility
If a port exists in both the block and allow list deny the request
Notes:
If we are open to API breaking changes I'd prefer to disallow non-standard ports by default