Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make sure yq is ready in windows runners #313

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: make sure yq is ready in windows runners #313

wants to merge 5 commits into from

Conversation

penkzhou
Copy link

@penkzhou penkzhou commented Jun 7, 2024

No description provided.

@penkzhou penkzhou changed the title Update action.yaml to make sure yq is ready feat: make sure yq is ready in windows runners Jun 7, 2024
bartekpacia
bartekpacia reviewed Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Please also update README.md to mention that we automatically install jq now.

@penkzhou
Copy link
Author

@bartekpacia README.md is updated.

@bartekpacia
Copy link
Collaborator

hey @penkzhou, would you rebase with master?

I can't push to your branch because it's main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartekpacia bartekpacia bartekpacia left review comments

@yurikoles yurikoles yurikoles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penkzhou @bartekpacia @yurikoles