Feat Nav buttons text configurable + add tests #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 19, 2024 14:58
…i file of german lang
paulpestov
reviewed
Sep 19, 2024
added 4 commits
September 20, 2024 09:59
paulpestov
reviewed
Sep 20, 2024
paulpestov
reviewed
Sep 20, 2024
|
@paulpestov I have one question: This branch does not have the latest develop (I think for instance the part with showing all collectors is not in this branch). But still this branch does not have merge conflicts with develop. There shouldn't be any problem with merging right ? We are just adding the additions of this PR to the develop and not removing any of the develop's actual state right ? I have added a latest commit to show the 'Sheet', 'Manuscript' only for Ahiqar editions. Feel free to continue reviewing. |
added 5 commits
September 20, 2024 18:57
it has to be fixed in later commits
paulpestov
reviewed
Sep 20, 2024
paulpestov
reviewed
Sep 20, 2024
It should work, lets see what happens |
paulpestov
reviewed
Sep 20, 2024
|
@paulpestov in my latest few commits I have tried to address your points. Please continue reviewing. |
paulpestov
reviewed
Sep 23, 2024
paulpestov
reviewed
Sep 23, 2024
paulpestov
reviewed
Sep 23, 2024
paulpestov
approved these changes
Sep 24, 2024
orlinmalkja
added a commit
that referenced
this pull request
Oct 8, 2024
* feat: make the header nav buttons text configurable * fix: resolve errors in app.cy tests regarding the title bar * fix: resolve errors regarding the content tests * fix: rewrite the old tests content as it was and add a arabic karshuni file of german lang * refactor: add ahiqar and gfl selektors in globals file * test: add tests for the feat header nav buttons text configurable * chore: restore the previous content in index.html * fix: add combined translation keys for the header nav buttons * test: adapt the header nav buttons text according to the new translation keys * chore: remove the 'labels' object from the gfl local example file * chore: restore the labels object in config of local files (arabic karshuni and gfl) * fix: show specific header nav button labels for the ahiqar editions * feat: make header navigation buttons text configurable for each project * test: remove the tests for arabic karshuni 'de' * chore: add in the translations key of config the (key,value) of nav buttons text * chore: remove the translations key values from i18n en for the ahiqar project * chore: set the 'item' label temporarily in Title bar it has to be fixed in later commits * chore: use the general keys (item and manifest) in config for the local files * feat: add nav buttons text configurable * fix: show the item name in the title of header based on nav buttons text * chore: remove ahiqar arabic karshuni local --------- Co-authored-by: malkja <[email protected]>
orlinmalkja
added a commit
that referenced
this pull request
Oct 8, 2024
* feat: make the header nav buttons text configurable * fix: resolve errors in app.cy tests regarding the title bar * fix: resolve errors regarding the content tests * fix: rewrite the old tests content as it was and add a arabic karshuni file of german lang * refactor: add ahiqar and gfl selektors in globals file * test: add tests for the feat header nav buttons text configurable * chore: restore the previous content in index.html * fix: add combined translation keys for the header nav buttons * test: adapt the header nav buttons text according to the new translation keys * chore: remove the 'labels' object from the gfl local example file * chore: restore the labels object in config of local files (arabic karshuni and gfl) * fix: show specific header nav button labels for the ahiqar editions * feat: make header navigation buttons text configurable for each project * test: remove the tests for arabic karshuni 'de' * chore: add in the translations key of config the (key,value) of nav buttons text * chore: remove the translations key values from i18n en for the ahiqar project * chore: set the 'item' label temporarily in Title bar it has to be fixed in later commits * chore: use the general keys (item and manifest) in config for the local files * feat: add nav buttons text configurable * fix: show the item name in the title of header based on nav buttons text * chore: remove ahiqar arabic karshuni local --------- Co-authored-by: malkja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.