TIDO v5: show panels wrapper which contains text and switch between different types of text content #533

orlinmalkja · 2024-11-29T15:42:35Z

No description provided.

orlinmalkja · 2024-11-29T15:53:21Z

@paulpestov Shall we display by default the first text content type or should one make the initial display configurable ?
I think it is not necessary to make it configurable, but just show initially the first text content type, it seems natural to me. The reason against making it configurable, is that obtaining the desired content type can be achieved by a very simple action - clicking at another button.

paulpestov · 2024-11-29T16:12:24Z

Somehow I get this error at npm run dev:

Error: The following dependencies are imported but could not be resolved:
primeicons/primeicons.css (imported by .../tido/src/App.tsx)
primereact/button (imported by .../tido/src/components/panel/TextTypes.tsx)

src/main.tsx

tsconfig.json

src/components/panel/Panel.tsx

orlinmalkja · 2024-11-29T16:22:02Z

Somehow I get this error at npm run dev:

Error: The following dependencies are imported but could not be resolved: primeicons/primeicons.css (imported by .../tido/src/App.tsx) primereact/button (imported by .../tido/src/components/panel/TextTypes.tsx)

have you installed primereact locally ?

paulpestov · 2024-11-29T16:28:58Z

I think its missing in package.json

…rapper component

…e its usage on different components

…ttribute name given in config

…onUrl()

src/components/panel/Panel.tsx

…r types

…nifest data from the document url 2. we get the item url based on the manifest data and the item index provided in the config

src/utils/http.tsx

src/config.tsx

index.html

… on a specified width %

…ns true or false

… item data

orlinmalkja · 2024-12-13T09:18:36Z

src/main.tsx

@@ -5,8 +5,14 @@ import './css/style.css'

 import App from './App.tsx'

-window.Tido = function Tido(config = {}) {
-    createRoot(document.getElementById('app')!).render(<App customConfig={config} />)
+declare global {


@paulpestov I merged the PR, but I have still one question. Which is the idea behind the lines 8-12 in this file ?

Just to satisfy Typescript

orlinmalkja added 9 commits November 28, 2024 13:44

chore: import css files to use default TIDO and tailwind css

30b4ec3

chore: define a basic default config

bbf544b

feat: add ConfigContext in the App

1015aa9

chore: use absolute path in the project

9fad0de

chore: movethe configuration of absolute path to tsconfig.json

6b1ad4a

feat: add text on each panel for each pre-configured panel

72001c8

feat: switch the text tab using buttons toggle

dca9e88

refactor: create a new component for the Text Switching buttons

640991e

chore: remove unneccessary span

7182af5

orlinmalkja requested a review from paulpestov November 29, 2024 15:42

orlinmalkja self-assigned this Nov 29, 2024

orlinmalkja changed the title ~~show panels wrapper which contains text and switch between different types of text content~~ TIDO v5: show panels wrapper which contains text and switch between different types of text content Nov 29, 2024

paulpestov reviewed Nov 29, 2024

View reviewed changes

src/main.tsx Outdated Show resolved Hide resolved

tsconfig.json Outdated Show resolved Hide resolved

src/components/panel/Panel.tsx Outdated Show resolved Hide resolved

src/components/panel/Panel.tsx Outdated Show resolved Hide resolved

orlinmalkja added 13 commits December 2, 2024 10:55

chore: add primereact as dev dependency

faf367d

chore: remove the import of primeicons

8463aae

chore: configure 'single' quotes in eslint config file

a749063

style: convert the 'double' to 'single' quotes

3321f4e

style: convert the 'double quotes' to 'single quotes' for the PanelsW…

1b80a18

…rapper component

refactor: define the ConfigProvider as a separate component and updat…

5c4757e

…e its usage on different components

refactor: differentiate between collection or manifest by using the a…

6dde4f9

…ttribute name given in config

wip(types): add panel config interface

ca6b896

chore: make the config smaller temporarily

6cb5a5c

chore: add types in the Panel component

d04af4e

chore: add types in ContentTypesToggle component

2be3ab0

chore: add further Typescript types to components

35f1192

refactor: add two separate functions getManifestUrl() and getCollecti…

5cb2e44

…onUrl()

paulpestov reviewed Dec 6, 2024

View reviewed changes

src/components/panel/Panel.tsx Outdated Show resolved Hide resolved

orlinmalkja added 7 commits December 8, 2024 18:41

style: rename the type for panel config to PanelConfig

a16ff7d

refactor: rewrite App component as FC component using an interface fo…

a10a199

…r types

chore: remove updateConfig in ConfigContext, instead just use setConfig

7bb74d7

refactor: remove redundant initOpenedPanels()

c0f7771

chore: add small eslint fixes

30d4c4a

chore: include error handling in get() which fetches api data

ed5232c

refactor: rewrite the logic of getting the item url: 1. we get the ma…

5d3e22c

…nifest data from the document url 2. we get the item url based on the manifest data and the item index provided in the config

paulpestov reviewed Dec 10, 2024

View reviewed changes

src/utils/http.tsx Outdated Show resolved Hide resolved

paulpestov reviewed Dec 10, 2024

View reviewed changes

src/config.tsx Outdated Show resolved Hide resolved

paulpestov reviewed Dec 10, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

orlinmalkja and others added 15 commits December 10, 2024 15:56

feat: introduce error handling for fetch request

e925221

refactor: remove useEffect in PanelsWrapper() since its not necessary

cddbfbc

style: remove semicolons

8710611

chore: add widthText as prop to CustomHTML component to show the text…

119d2a6

… on a specified width %

refactor: assign only one task to isDataFetchedCorrectly, which retur…

fc4caca

…ns true or false

refactor: add try catch in Panel.tsx when receiving the response

ee60244

refactor: rewrite getManifestUrl()

590a149

wip(read Data): restructure readData, use the entrypoint as an object

76c7e42

refactor(read Data): write separate function for reading Manifest and…

a21954b

… item data

refactor: update http client for type safety

1bccadf

chore: make app component cleaner

585a342

refactor: use clicked index to update the active content text index

fdcb737

refactor: write more compact/pure the function assignContentTypes()

8728873

chore: remove unnecessary function getActiveContentUrl()

42c36d5

refactor: update linting rules and code style

d81f4c0

paulpestov approved these changes Dec 12, 2024

View reviewed changes

orlinmalkja merged commit 43d30a7 into next Dec 13, 2024
2 checks passed

orlinmalkja deleted the panel-render branch December 13, 2024 09:16

orlinmalkja commented Dec 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TIDO v5: show panels wrapper which contains text and switch between different types of text content #533

TIDO v5: show panels wrapper which contains text and switch between different types of text content #533

orlinmalkja commented Nov 29, 2024

orlinmalkja commented Nov 29, 2024

paulpestov commented Nov 29, 2024 •

edited

Loading

orlinmalkja commented Nov 29, 2024

paulpestov commented Nov 29, 2024

orlinmalkja Dec 13, 2024

paulpestov Dec 13, 2024

TIDO v5: show panels wrapper which contains text and switch between different types of text content #533

TIDO v5: show panels wrapper which contains text and switch between different types of text content #533

Conversation

orlinmalkja commented Nov 29, 2024

orlinmalkja commented Nov 29, 2024

paulpestov commented Nov 29, 2024 • edited Loading

orlinmalkja commented Nov 29, 2024

paulpestov commented Nov 29, 2024

orlinmalkja Dec 13, 2024

Choose a reason for hiding this comment

paulpestov Dec 13, 2024

Choose a reason for hiding this comment

paulpestov commented Nov 29, 2024 •

edited

Loading