Width config #540
Merged
Width config #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd overflow horizontally, update mobile panel design to be full width
paulpestov
force-pushed
the
width-config
branch
from
601275b to
df4aa17
Compare
orlinmalkja
reviewed
Dec 13, 2024
orlinmalkja
reviewed
Dec 13, 2024
|
|
||
| const onResize = (callback) => { | ||
| resizeSubscribers.add(callback); | ||
| return () => resizeSubscribers.delete(callback); // Return an unsubscribe function |
There was a problem hiding this comment.
I have a question here: When will this delete function be executed ? On a normal resize of the window, it is not executed, only the function definition is returned..
There was a problem hiding this comment.
There was a problem hiding this comment.
what I see on top from the above link is 'watch(configStore.config, () => {
updatePanelWidth(isMobile.value)
})'
Is this what you meant ?
There was a problem hiding this comment.
No, its in the PanelWrapper in the onUnount
orlinmalkja
reviewed
Dec 13, 2024
orlinmalkja
reviewed
Dec 13, 2024
| if (container.value) { | ||
| defaultWidth.value = isMobile ? container.value.clientWidth - panelWrapperPadding : container.value.clientWidth / panels.value.filter(({ show }) => !!(show)).length - panelMargin; | ||
| } | ||
| return 300; |
There was a problem hiding this comment.
Is this return statement needed ? I don't see whether it is assigned to some variable.
There was a problem hiding this comment.
If the container does not exist yet.
orlinmalkja
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with appending "width" config options to each panel config item. Check the README updates for how to configure.
Closes #368