Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title: Restore Acknowledgements, Add Performance Test #1828

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

savvar9991
Copy link

Title: Restore Acknowledgements, Add Performance Test, and Update Canonical Verifier Gateways

Description:

This pull request introduces several key improvements, including restoring missing acknowledgements

Changes:

  • Canonical Verifier Gateways: Clarified the distinction between the different verifier gateways used for each proof system (Groth16 and PLONK). Users must now ensure they are using the correct verifier gateway depending on whether they are verifying a Groth16 or PLONK proof.
  • Restored Acknowledgements: Reintroduced the acknowledgements functionality that had been missing in previous versions. This ensures the verification process properly handles and responds to acknowledgements.

Explanation: the word "gateway" should be in the plural, since we are talking about several gateways for different evidence systems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant