feat: add hash_public_values
#730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ratankaliani
commented
May 14, 2024
jtguibas
approved these changes
May 14, 2024
core/src/io.rs
Outdated
| @@ -127,6 +129,26 @@ impl SP1PublicValues { | |||
| pub fn write_slice(&mut self, slice: &[u8]) { | |||
| self.buffer.write_slice(slice); | |||
| } | |||
|
|
|||
| /// Hash the public values, mask the top 3 bits and return a BigUint. | |||
There was a problem hiding this comment.
nit: comment doens't seem to span 100 columns?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
hash_public_valuestocoreto mirror the implementation ofhashPublicValuesin the Solidity verifier. This will be useful in #729, where we'll add proof verification.