feat: exit code #750
Merged
feat: exit code #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tamir Hemo <[email protected]> Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Kevin Jue <[email protected]> Co-authored-by: Tarik Moon <[email protected]> Co-authored-by: Matthias Görgens <[email protected]> Co-authored-by: Eugene Rabinovich <[email protected]>
jtguibas
approved these changes
May 17, 2024
jtguibas
reviewed
May 17, 2024
core/src/cpu/air/ecall.rs
Outdated
| @@ -181,6 +182,11 @@ impl CpuChip { | |||
| .assert_zero(next.is_real); | |||
|
|
|||
| builder.when(is_halt.clone()).assert_zero(local.next_pc); | |||
|
|
|||
| builder.when(is_halt.clone()).assert_eq( | |||
| local.op_a_access.prev_value().reduce::<AB>(), | |||
| { | ||
| let is_system_instruction = self.is_system_instruction::<AB>(local); | ||
|
|
||
| // Verify that the last real row is either TRAP or HALT. |
erabinov
added a commit
that referenced
this pull request
May 24, 2024
Co-authored-by: John Guibas <[email protected]> Co-authored-by: Tamir Hemo <[email protected]> Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Tarik Moon <[email protected]> Co-authored-by: Matthias Görgens <[email protected]> Co-authored-by: Eugene Rabinovich <[email protected]> Co-authored-by: Chris Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.