Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add example program to test patches #950

Merged
merged 28 commits into from
Jun 19, 2024
Merged

Conversation

ratankaliani
Copy link
Member

@ratankaliani ratankaliani commented Jun 17, 2024

Add example program to test patches.

  • Note: This program currently doesn't test curve25519-dalek because that patch is incomplete: feat: patch v4.1.3 sp1-patches/curve25519-dalek#1
  • Also, it is not possible to test SHA patches of the same minor version at the same time due to Cargo dependency resolution, so for now, we just test one of the minor versions.

Also, fixes the issues in the Examples Github Action.

@ratankaliani ratankaliani marked this pull request as draft June 17, 2024 22:10
@ratankaliani ratankaliani marked this pull request as ready for review June 18, 2024 19:23
@ratankaliani ratankaliani changed the title feat: add patch test example program feat: Add example program to test patches.; Jun 18, 2024
@ratankaliani ratankaliani changed the title feat: Add example program to test patches.; feat: Add example program to test patches. Jun 18, 2024
@ratankaliani ratankaliani changed the title feat: Add example program to test patches. feat: Add example program to test patches Jun 18, 2024
@ratankaliani ratankaliani merged commit 1a3ea8d into dev Jun 19, 2024
5 of 6 checks passed
@ratankaliani ratankaliani deleted the ratan/patch-testing branch June 19, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants