Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplification and refactoring #16

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Simplification and refactoring #16

wants to merge 8 commits into from

Conversation

ky1ejs
Copy link

@ky1ejs ky1ejs commented May 18, 2016

This PR brings:

  • Simplified initialisation of ConfettiView
  • Better adherence to Swift type naming (ConfettiView instead of SAConfettiView)
  • Refactor and encapsulation of ConfettiType

This PR fixes:

  • An issue where confetti would not start from the top of the screen
  • An issue where the frame in which confetti falls would not be update with layout change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ky1ejs