-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 8.3 and Swift 3.1 support #38
base: master
Are you sure you want to change the base?
Conversation
…ft 3.1 and Xcode 8.3
@sudeepag any update on when you will merge this? |
@saldous your branch has several error apparently :( |
Odd, as you can see I only changed 2 lines of code! Looks like other Swift 3.1 changes are needed. |
Would you fix those errors please? |
Don't want to hijack your effort & work :) I should've a running version here: https://github.com/ctews/SAConfettiView maybe your can merge in those changes into your PR branch! :) |
|
Changed M_PI and M_PI_4 to Double.pi and Double.pi / 4 to support Xcode 8.3 and Swift 3.1 changes.