-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.midi Export #4319
base: master
Are you sure you want to change the base?
.midi Export #4319
Conversation
I am close to completing this feature 👍 |
fixes:#4311 @pikurasa I think the PR is ready for review. Please check it. Next, I have to work on adding instruments to the MIDI file. After exporting, you can play the MIDI file in media players like Windows Media Player. Right now, it will only play on the piano. |
@pikurasa The midi export is finally done. Please review this PR. final.mp4For testing we can use : https://pianotify.com/import-midi-file |
I tested https://github.com/sugarlabs/musicblocks/blob/master/examples/Holly-Jolly-Christmas.html, and the output seems to get off track after the third note. This is the MIDI file generated while on your branch, |
@pikurasa, I have fixed the issue. I thought _midiData was filled instantly, but that is not the case. It takes some time to retrieve all the data. Like Lilypond and others, I have created an after-save function to generate a MIDI file when midi data is filled. Here is the result :-> midi2.mp4 |
To export .midi this PR uses the library tones/midi.