increase nginx buffer size when proxifying keycloak #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunika
force-pushed
the
fix/keycloak-create-user
branch
from
d9be049 to
906c567
Compare
AntoLC
approved these changes
Feb 14, 2025
Comment on lines
-92
to
-111
| - name: Install Dockerize | ||
| run: | | ||
| curl -sSL https://github.com/jwilder/dockerize/releases/download/v0.8.0/dockerize-linux-amd64-v0.8.0.tar.gz | sudo tar -C /usr/local/bin -xzv | ||
|
|
||
| - name: Wait for services to be ready | ||
| run: | | ||
| printf "Minio check...\n" | ||
| dockerize -wait tcp://localhost:9000 -timeout 20s | ||
| printf "Keyclock check...\n" | ||
| dockerize -wait tcp://localhost:8080 -timeout 20s | ||
| printf "Server collaboration check...\n" | ||
| dockerize -wait tcp://localhost:4444 -timeout 20s | ||
| printf "Ngnix check...\n" | ||
| dockerize -wait tcp://localhost:8083 -timeout 20s | ||
| printf "DRF check...\n" | ||
| dockerize -wait tcp://localhost:8071 -timeout 20s | ||
| printf "Postgres Keyclock check...\n" | ||
| dockerize -wait tcp://localhost:5433 -timeout 20s | ||
| printf "Postgres back check...\n" | ||
| dockerize -wait tcp://localhost:15432 -timeout 20s |
There was a problem hiding this comment.
It solves some flakiness, but let's see.
lunika
force-pushed
the
fix/keycloak-create-user
branch
2 times, most recently
from
160ec77 to
08e45d8
Compare
Nginx is used to proxify keycloak in our development configuration. When a new user is created keycloak is send a large amount of headers in its response and the default nginx config is not enough to handle this amount of headers. We have to increase the proxy buffer size to handle them.
We remove dockerize and use healthcheck on docker compose services instead.
The run command is not starting the frontend application. We change the run commands. The run command is strating everything. The run-backend command is starting all services needed to use the backend application.
The frontend-dev service is in fact using the production image. We rename it in frontend accordingly with what it really does. We also have to change name rules in Makefile to be consistent.
lunika
force-pushed
the
fix/keycloak-create-user
branch
from
08e45d8 to
ee4402e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Nginx is used to proxify keycloak in our development configuration. When
a new user is created keycloak is send a large amount of headers in its
response and the default nginx config is not enough to handle this
amount of headers. We have to increase the proxy buffer size to handle
them.
We all remove the usage of dockerize in this PR to use healthcheck in docker compose services.
And then change all make run commands. The run command is starting everything. The run-back
command is starting all services needed to use the backend application
and then the run-frontend starts only the frontend-dev service.
Proposal