feat(core,common): improve adapter resolution strategy #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #213 +/- ##
==========================================
+ Coverage 91.86% 93.15% +1.28%
==========================================
Files 13 15 +2
Lines 246 292 +46
Branches 43 50 +7
==========================================
+ Hits 226 272 +46
+ Misses 13 12 -1
- Partials 7 8 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AInclude additional methods in the unit reference to utilize identifier metadata.
AInclude additional methods in the unit reference to utilize identifier metadata.
omermorad
changed the title
omermorad
approved these changes
Dec 6, 2023
|
@yaron-shamul Nice work buddy!! 🚀 🚀 |
omermorad
added a commit
that referenced
this pull request
Dec 7, 2023
Incorporated additional functionality to read the `package.json` file, extracting both dependencies and devDependencies, and resolving the adapter from that list. This mechanism is implemented prior to the base mechanism of attempting to globally resolve the adapters package (module) using node require.resolve. Co-authored-by: Omer Morad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
As of today, the Automock iterates through the supported adapters, attempting to import each one until it successfully imports one. It is imperative to enhance this process for improved efficiency and reliability.
Issue Number: #193
What is the new behavior?
Added new functionality to read package.json extracting both dependencies and dev-dependencies and resolving the first supported adapter. This refined capability allows the system to intelligently resolve the first supported adapter with unparalleled precision and efficiency.
Does this PR introduce a breaking change?
Other information