Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): fix typo in link to docs #219

Closed
wants to merge 2 commits into from
Closed

docs(core): fix typo in link to docs #219

wants to merge 2 commits into from

Conversation

elwinschmitz
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Documentation/error-message fix

What is the current behavior?

The error-message(s) are referring to an incorrect URL for the documentation.

Issue Number: N/A

What is the new behavior?

The URL is changed to the correct documentation-website.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I don't know if there are any other requirements for a first-time contribution, so let me know if I missed something.

@elwinschmitz elwinschmitz changed the title docs(core): Fix type in link to docs docs(core): Fix typo in link to docs Dec 6, 2023
@omermorad omermorad changed the title docs(core): Fix typo in link to docs docs(core): fix typo in link to docs Dec 6, 2023
@omermorad omermorad self-requested a review December 6, 2023 13:23
@omermorad omermorad changed the base branch from master to next December 6, 2023 13:32
@omermorad
Copy link
Collaborator

@elwinschmitz thank you for this :)
I think there is an issue with Github actions. I will trigger the action again soon 🚀

@elwinschmitz
Copy link
Author

@omermorad Ah, I see now that the typo isn't present anymore in the next branch... But I didn't check there...

So I guess my 'issue' is already fixed in the upcoming version?

@omermorad omermorad closed this Dec 7, 2023
@elwinschmitz elwinschmitz deleted the docs--fix-type branch December 7, 2023 09:11
@omermorad
Copy link
Collaborator

@elwinschmitz yes, sorry! I did not pay attention to it 😅
Yes, it will be fixed in the next upcoming version 🚀

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants