OpenAlex DOI lookups with invalid parameters #77
Merged
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwrubel
commented
Jul 8, 2024
test/harvest/test_openalex.py
Outdated
| @@ -50,11 +50,20 @@ def test_publications_from_dois(): | |||
| pubs = list(openalex.publications_from_dois(dois)) | |||
| assert len(pubs) == 231, "should paginate (page size=200)" | |||
| assert len(pubs) == len(set([pub["doi"] for pub in pubs])), "DOIs are unique" | |||
| assert set(openalex.FIELDS) == set(pubs[0].keys()), "All fields accounted for." | |||
There was a problem hiding this comment.
I didn't mean to delete this assertion. Fixing.
edsu
approved these changes
Jul 8, 2024
| assert len(pubs[0].keys()) == 51, "first publication has 51 columns" | ||
| assert len(pubs[1].keys()) == 51, "second publication has 51 columns" | ||
|
|
||
|
|
||
| def test_publications_from_invalid_dois(caplog): |
There was a problem hiding this comment.
Nice, I didn't know about caplog from pytest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #76 to retry DOIs in a batch if one proves invalid (because of a comma or some other issue).