Extract logic about querying service points to a new class #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
service_point_store
branch
from
5e0b2ef to
6ca0faf
Compare
|
Is this going to make a nasty conflict with #1638? |
jcoyne
force-pushed
the
service_point_store
branch
5 times, most recently
from
ea0aa1c to
723ebe8
Compare
jcoyne
force-pushed
the
service_point_store
branch
from
723ebe8 to
c830237
Compare
|
I'd selfishly like to get #1725 in first; we've done similar refactoring, but I think it'll be easier to rebase these changes on that instead of the other way around. |
|
I've merged this into #1725. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.