do not remove middle name variants from the query when the user has a middle name entered #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
force-pushed
the
1081-middle-name-variants
branch
2 times, most recently
from
40cd047
to
96509ea
Compare
… middle name entered
peetucket
force-pushed
the
1081-middle-name-variants
branch
from
96509ea
to
baa7549
Compare
|
Not sure this makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible option for #1081
Rather than blindly remove the middle name variant for all queries, let's only remove if the user really has not entered a middle name. It should improve results for users with middle names.
Requires some coordination with Profiles team to validate the approach