Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] add provenance convenience column to pub table table #1458

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peetucket
Copy link
Member

@peetucket peetucket commented Mar 11, 2022

Why was this change made?

Fixes #652 - this will make it easier to run some analysis queries about where publications originally came from without resorting to identifiers or inspecting the pub_hash. Note that this change will need a migration to the database, adding a column and an index to a big table, so may want to do off hours in case it takes a while.

Hold for now so we can plan this for a good time.

we will then want to run the rake task to back-fill data

How was this change tested?

Localhost

Which documentation and/or configurations were updated?

@peetucket peetucket changed the title add provenance convenience column to pub table table [HOLD] add provenance convenience column to pub table table Mar 11, 2022
@peetucket peetucket force-pushed the add-provenance branch 3 times, most recently from 69add7f to f726205 Compare March 18, 2022 17:36
Copy link
Member

@jmartin-sul jmartin-sul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nitpick, but wouldn't hold up merging over it

app/models/publication.rb Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make provenance a publication level AR field
2 participants