Fix registration error caused by a non-existing role name. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UserManager->createUserRole uses the role key instead of the role name to create a new user, because the role name should be only a human readable value and not a key
| @@ -180,7 +180,7 @@ public function getUniqueToken(string $field): string | |||
| protected function createUserRole(User $user, string $webspaceKey, string $roleName): UserRole | |||
| { | |||
| /** @var RoleInterface $role */ | |||
| $role = $this->roleRepository->findOneBy(['name' => $roleName]); | |||
| $role = $this->roleRepository->findOneBy(['key' => $roleName]); | |||
There was a problem hiding this comment.
Thank you for the pull request! It looks like this is a bug and was forgotten to be changed in #130.
Unfortunately, the new implementation might break things for users that use an older Sulu version. Therefore we need to fallback to the old behaviour like in the InitCommand:
SuluCommunityBundle/Command/InitCommand.php
Lines 146 to 153 in 9a5da07
Also, i think it would be nice to update the code and use roleKey instead of roleName as variable name in the InitCommand, UserManager and UserManagerInterface 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserManager->createUserRole uses the role key instead of the role name to create a new user, because the role name should be only a human readable value and not a key
What's in this PR?
the commit-msg describes itself
Why?