Update baseline

sulu · Apr 19, 2024 · 37fa4ff · 37fa4ff
1 parent 02cd778
commit 37fa4ff
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 30 deletions.
diff --git a/DependencyInjection/SuluFormExtension.php b/DependencyInjection/SuluFormExtension.php
@@ -212,6 +212,7 @@ public function load(array $configs, ContainerBuilder $container): void
             $loader->load('type_mailchimp.xml');
         }
 
+        /** @var array<string, class-string> $bundles */
         $bundles = $container->getParameter('kernel.bundles');
 
         if (\array_key_exists('SuluArticleBundle', $bundles)) {

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -15,6 +15,11 @@ parameters:
 			count: 1
 			path: Admin/DynamicListAdmin.php
 
+		-
+			message: "#^Method Sulu\\\\Bundle\\\\FormBundle\\\\Admin\\\\FormAdmin\\:\\:getSecurityContexts\\(\\) should return array\\<string, array\\<string, array\\<string, array\\<string\\>\\>\\>\\> but returns array\\<string, array\\<string, array\\<int\\|string, array\\<int, string\\>\\>\\>\\>\\.$#"
+			count: 1
+			path: Admin/FormAdmin.php
+
 		-
 			message: "#^Cannot call method setForm\\(\\) on Sulu\\\\Bundle\\\\FormBundle\\\\Entity\\\\FormTranslation\\|null\\.$#"
 			count: 1
@@ -236,7 +241,7 @@ parameters:
 			path: Controller/DynamicController.php
 
 		-
-			message: "#^Parameter \\#6 \\$limit of class Sulu\\\\Component\\\\Rest\\\\ListBuilder\\\\ListRepresentation constructor expects int, mixed given\\.$#"
+			message: "#^Parameter \\#6 \\$limit of class Sulu\\\\Component\\\\Rest\\\\ListBuilder\\\\ListRepresentation constructor expects int\\|null, mixed given\\.$#"
 			count: 1
 			path: Controller/DynamicController.php
 
@@ -315,6 +320,16 @@ parameters:
 			count: 2
 			path: Controller/FormWebsiteController.php
 
+		-
+			message: "#^Parameter \\#1 \\$type of method Symfony\\\\Component\\\\Form\\\\FormFactory\\:\\:create\\(\\) expects class\\-string\\<TFormType of Symfony\\\\Component\\\\Form\\\\FormTypeInterface\\<array\\{\\}\\>\\>, string given\\.$#"
+			count: 1
+			path: Controller/FormWebsiteController.php
+
+		-
+			message: "#^Parameter \\#1 \\$type of method Symfony\\\\Component\\\\Form\\\\FormFactory\\:\\:create\\(\\) expects class\\-string\\<TFormType of Symfony\\\\Component\\\\Form\\\\FormTypeInterface\\<null\\>\\>, string given\\.$#"
+			count: 1
+			path: Controller/FormWebsiteController.php
+
 		-
 			message: "#^Parameter \\#1 \\$template of method Sulu\\\\Bundle\\\\FormBundle\\\\Provider\\\\ListProviderRegistry\\:\\:getEntityName\\(\\) expects string, mixed given\\.$#"
 			count: 1
@@ -370,11 +385,6 @@ parameters:
 			count: 1
 			path: DependencyInjection/CompilerPass/RemoveTaggedServiceCollectorCompilerPass.php
 
-		-
-			message: "#^Call to function array_key_exists\\(\\) with 'SuluArticleBundle' and array\\{FrameworkBundle\\: string, TwigBundle\\: string, SuluCoreBundle\\: string, DoctrineBundle\\: string, DoctrinePHPCRBundle\\: string, PhpcrMigrationsBundle\\: string, StofDoctrineExtensionsBundle\\: string, JMSSerializerBundle\\: string, \\.\\.\\.\\} will always evaluate to false\\.$#"
-			count: 1
-			path: DependencyInjection/SuluFormExtension.php
-
 		-
 			message: "#^Cannot access offset 'helper' on mixed\\.$#"
 			count: 1
@@ -452,7 +462,7 @@ parameters:
 
 		-
 			message: "#^Cannot access offset 'placeholder' on mixed\\.$#"
-			count: 3
+			count: 2
 			path: Dynamic/Types/CheckboxMultipleType.php
 
 		-
@@ -507,7 +517,7 @@ parameters:
 
 		-
 			message: "#^Cannot access offset 'placeholder' on mixed\\.$#"
-			count: 3
+			count: 2
 			path: Dynamic/Types/CountryType.php
 
 		-
@@ -522,7 +532,7 @@ parameters:
 
 		-
 			message: "#^Cannot access offset 'placeholder' on mixed\\.$#"
-			count: 3
+			count: 2
 			path: Dynamic/Types/DropdownMultiple.php
 
 		-
@@ -562,7 +572,7 @@ parameters:
 
 		-
 			message: "#^Cannot access offset 'placeholder' on mixed\\.$#"
-			count: 3
+			count: 2
 			path: Dynamic/Types/DropdownType.php
 
 		-
@@ -630,6 +640,11 @@ parameters:
 			count: 1
 			path: Dynamic/Types/HeadlineType.php
 
+		-
+			message: "#^Cannot call method getDefaultValue\\(\\) on Sulu\\\\Bundle\\\\FormBundle\\\\Entity\\\\FormFieldTranslation\\|null\\.$#"
+			count: 1
+			path: Dynamic/Types/HiddenType.php
+
 		-
 			message: "#^Cannot call method getDefaultValue\\(\\) on Sulu\\\\Bundle\\\\FormBundle\\\\Entity\\\\FormFieldTranslation\\|null\\.$#"
 			count: 1
@@ -647,7 +662,7 @@ parameters:
 
 		-
 			message: "#^Cannot access offset 'placeholder' on mixed\\.$#"
-			count: 3
+			count: 2
 			path: Dynamic/Types/RadioButtonsType.php
 
 		-
@@ -991,7 +1006,7 @@ parameters:
 			path: Event/ProtectedMediaSubscriber.php
 
 		-
-			message: "#^Parameter \\#1 \\$haystack of function strpos expects string, mixed given\\.$#"
+			message: "#^Parameter \\#1 \\$haystack of function strpos expects string, bool\\|float\\|int\\|string\\|null given\\.$#"
 			count: 1
 			path: Event/ProtectedMediaSubscriber.php
 
@@ -1141,7 +1156,7 @@ parameters:
 			path: Form/Builder.php
 
 		-
-			message: "#^Cannot call method getData\\(\\) on Symfony\\\\Component\\\\Form\\\\FormInterface\\|null\\.$#"
+			message: "#^Cannot call method getData\\(\\) on Symfony\\\\Component\\\\Form\\\\FormInterface\\<mixed\\>\\|null\\.$#"
 			count: 4
 			path: Form/Handler.php
 
@@ -1172,7 +1187,7 @@ parameters:
 
 		-
 			message: "#^Cannot access offset string on mixed\\.$#"
-			count: 2
+			count: 1
 			path: Form/Type/AbstractType.php
 
 		-
@@ -1397,14 +1412,24 @@ parameters:
 
 		-
 			message: "#^Argument of an invalid type mixed supplied for foreach, only iterables are supported\\.$#"
-			count: 2
+			count: 3
 			path: Manager/FormManager.php
 
 		-
 			message: "#^Cannot access offset 'email' on mixed\\.$#"
 			count: 1
 			path: Manager/FormManager.php
 
+		-
+			message: "#^Cannot access offset 'id' on mixed\\.$#"
+			count: 3
+			path: Manager/FormManager.php
+
+		-
+			message: "#^Cannot access offset 'key' on mixed\\.$#"
+			count: 3
+			path: Manager/FormManager.php
+
 		-
 			message: "#^Cannot access offset 'name' on mixed\\.$#"
 			count: 2
@@ -1415,6 +1440,11 @@ parameters:
 			count: 1
 			path: Manager/FormManager.php
 
+		-
+			message: "#^Cannot access offset mixed on mixed\\.$#"
+			count: 2
+			path: Manager/FormManager.php
+
 		-
 			message: "#^Cannot call method getId\\(\\) on Sulu\\\\Bundle\\\\FormBundle\\\\Entity\\\\FormFieldTranslation\\|null\\.$#"
 			count: 1
@@ -1650,6 +1680,11 @@ parameters:
 			count: 1
 			path: Manager/FormManager.php
 
+		-
+			message: "#^Unreachable statement \\- code above always terminates\\.$#"
+			count: 1
+			path: Manager/FormManager.php
+
 		-
 			message: "#^Parameter \\#1 \\$title of method Sulu\\\\Bundle\\\\FormBundle\\\\Media\\\\CollectionStrategyTree\\:\\:createCollection\\(\\) expects string, string\\|null given\\.$#"
 			count: 1
@@ -1690,26 +1725,11 @@ parameters:
 			count: 1
 			path: Metadata/PropertiesXmlLoader.php
 
-		-
-			message: "#^Cannot cast mixed to int\\.$#"
-			count: 1
-			path: Repository/DynamicRepository.php
-
-		-
-			message: "#^Method Sulu\\\\Bundle\\\\FormBundle\\\\Repository\\\\DynamicRepository\\:\\:findByFilters\\(\\) should return array but returns mixed\\.$#"
-			count: 1
-			path: Repository/DynamicRepository.php
-
 		-
 			message: "#^Parameter \\#2 \\$fromDate of method Sulu\\\\Bundle\\\\FormBundle\\\\Repository\\\\DynamicRepository\\:\\:addDateRangeFilter\\(\\) expects string\\|null, mixed given\\.$#"
 			count: 1
 			path: Repository/DynamicRepository.php
 
-		-
-			message: "#^Cannot cast mixed to int\\.$#"
-			count: 1
-			path: Repository/FormRepository.php
-
 		-
 			message: "#^Method Sulu\\\\Bundle\\\\FormBundle\\\\Repository\\\\FormRepository\\:\\:getValue\\(\\) should return int\\|null but returns mixed\\.$#"
 			count: 2