Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Jekyll >= 3.2 #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

csware
Copy link

@csware csware commented Jul 19, 2017

Fixes issue #3.

Signed-off-by: Sven Strickroth <[email protected]>
@sumdog
Copy link
Owner

sumdog commented Jul 25, 2017

Hey csware, I'd like to get your stuff merged in and create a 0.4 release. I'm having trouble getting some of my tests working. I think my own site/plugins might have some weird interactions with Jekyll. If I try your fixes branch, I see the following:

Error reading file /home/cassius/webspace/battlepenguin/_layouts/category_index.html: No such file or directory @ rb_sysopen - /home/cassius/webspace/battlepenguin/_penguindreams/home/cassius/webspace/battlepenguin/_layouts/category_index.html 
Error reading file /home/cassius/webspace/battlepenguin/_layouts/post.html: No such file or directory @ rb_sysopen - /home/cassius/webspace/battlepenguin/_penguindreams/home/cassius/webspace/battlepenguin/_layouts/post.html 
Error reading file /home/cassius/webspace/battlepenguin/_layouts/default.html: No such file or directory @ rb_sysopen - /home/cassius/webspace/battlepenguin/_penguindreams/home/cassius/webspace/battlepenguin/_layouts/default.html 
Error reading file /home/cassius/webspace/battlepenguin/_layouts/page.html: No such file or directory @ rb_sysopen - /home/cassius/webspace/battlepenguin/_penguindreams/home/cassius/webspace/battlepenguin/_layouts/page.html 

and your newer combined-fixes branch doesn't work with my old version of Jekyll (3.0.1), which I honestly probably won't upgrade from.

jekyll 3.0.1 | Error:  Invalid hook. site supports only the following hooks [:after_reset, :post_read, :pre_render, :post_render, :post_write]

Could you submit a pull request for combined-fixes onto the csware branch? I'll get that merged in and see if I can get my testing branch to pass. If that works, I'll make a new release and create a comparability matrix in the README.

@csware
Copy link
Author

csware commented Jul 25, 2017

The combines-fixes branch is just this PR and my other PR combined (I use it here: https://gitlab.com/tortoisegit/tortoisegit.org). I submitted individual PRs so that those can be individually applied (PR #1 for the Jekyll 3.0.x version and this one for compatibility with Jekyll >=3.2)).

I suppose the error you are seeing is a WIndows/*nix incompatibility which I might have introduced in the other PR (maybe we need to make the change in 52870c0 (and/or 5b3dc16) conditional on the OS).

@sumdog
Copy link
Owner

sumdog commented Jul 26, 2017

Yes, I was just looking at your combined-fixes branch so I could test all the changes at once. :)

What operating system are you on? Mac? (I'm on Linux myself)

@csware
Copy link
Author

csware commented Jul 26, 2017

I'm on Windows.

@csware
Copy link
Author

csware commented Apr 28, 2020

@sumdog I fixed the issue you reported, see a822ff4

@sumdog
Copy link
Owner

sumdog commented Apr 28, 2020

@sumdog I fixed the issue you reported, see a822ff4

Hey. Thanks so much for still using this. I actually stopped using this after my big redesign last year.

Would you be interested in taking ownership of the gem? I've never transfered a gem before, but it looks like I can add you as an owner via your e-mail address. I could adjust the README to point to your fork as the latest official version.

@csware
Copy link
Author

csware commented Apr 29, 2020

Yeah, I'd like to. I suppose I've to maintain it anyways. My username is mrtux ([email protected]) on rubygems.

@csware
Copy link
Author

csware commented Apr 30, 2020

@sumdog Any news on this?

@sumdog
Copy link
Owner

sumdog commented May 1, 2020

@csware Sorry, got caught up with work. Thanks for reminding me. I've updated the README to point to your fork and have given you admin access on the gem. Thanks for your work contributing.

Please remember the license for this project is GPLv3.

Thanks 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants