-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compatible with Jekyll >= 3.2 #4
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Sven Strickroth <[email protected]>
Hey csware, I'd like to get your stuff merged in and create a 0.4 release. I'm having trouble getting some of my tests working. I think my own site/plugins might have some weird interactions with Jekyll. If I try your fixes branch, I see the following:
and your newer combined-fixes branch doesn't work with my old version of Jekyll (3.0.1), which I honestly probably won't upgrade from.
Could you submit a pull request for combined-fixes onto the csware branch? I'll get that merged in and see if I can get my testing branch to pass. If that works, I'll make a new release and create a comparability matrix in the README. |
The combines-fixes branch is just this PR and my other PR combined (I use it here: https://gitlab.com/tortoisegit/tortoisegit.org). I submitted individual PRs so that those can be individually applied (PR #1 for the Jekyll 3.0.x version and this one for compatibility with Jekyll >=3.2)). I suppose the error you are seeing is a WIndows/*nix incompatibility which I might have introduced in the other PR (maybe we need to make the change in 52870c0 (and/or 5b3dc16) conditional on the OS). |
Yes, I was just looking at your What operating system are you on? Mac? (I'm on Linux myself) |
I'm on Windows. |
Signed-off-by: Sven Strickroth <[email protected]>
Hey. Thanks so much for still using this. I actually stopped using this after my big redesign last year. Would you be interested in taking ownership of the gem? I've never transfered a gem before, but it looks like I can add you as an owner via your e-mail address. I could adjust the README to point to your fork as the latest official version. |
Yeah, I'd like to. I suppose I've to maintain it anyways. My username is |
@sumdog Any news on this? |
@csware Sorry, got caught up with work. Thanks for reminding me. I've updated the README to point to your fork and have given you admin access on the gem. Thanks for your work contributing. Please remember the license for this project is GPLv3. Thanks 😀 |
Fixes issue #3.