Modified opitka.sensors.AbstractImagingSensor.readout() to more gra…

…cefully deal with negative photons.
sun-data · Nov 6, 2024 · 336e999 · 336e999
1 parent f62246d
commit 336e999
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/optika/sensors/_sensors.py b/optika/sensors/_sensors.py
@@ -116,9 +116,11 @@ def readout(
 
         where = where & rays.unvignetted
 
+        sgn = np.sign(rays.intensity)
+
         rays = dataclasses.replace(
             rays,
-            intensity=rays.intensity * timedelta,
+            intensity=np.abs(rays.intensity) * timedelta,
         )
 
         normal = self.sag.normal(rays.position)
@@ -128,6 +130,11 @@ def readout(
             normal=normal,
         )
 
+        rays = dataclasses.replace(
+            rays,
+            intensity=sgn * rays.intensity,
+        )
+
         rays = self.material.charge_diffusion(
             rays=rays,
             normal=normal,
@@ -151,7 +158,7 @@ def readout(
                 wavelength=np.mean(rays.wavelength, axis=axis),
                 position=hist.inputs,
             ),
-            outputs=hist.outputs,
+            outputs=np.maximum(hist.outputs, 0),
         )