Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an introduction and a prime-focus telescope tutorial to the documentation. #92

Merged
merged 16 commits into from
Oct 12, 2024

Conversation

byrdie
Copy link
Collaborator

@byrdie byrdie commented Oct 9, 2024

No description provided.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.07%. Comparing base (d408891) to head (5421a83).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files          91       91           
  Lines        4773     4774    +1     
=======================================
+ Hits         4729     4730    +1     
  Misses         44       44           
Flag Coverage Δ
unittests 99.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byrdie
Copy link
Collaborator Author

byrdie commented Oct 10, 2024

@wtbarnes, would you consider a short review about it reads from someone outside the project?

@byrdie byrdie changed the title Added an introduction and a list of features to the documentation. Added an introduction and a Herschelian telescope tutorial to the documentation. Oct 10, 2024
@byrdie byrdie changed the title Added an introduction and a Herschelian telescope tutorial to the documentation. Added an introduction and a prime focus telescope tutorial to the documentation. Oct 12, 2024
@byrdie byrdie changed the title Added an introduction and a prime focus telescope tutorial to the documentation. Added an introduction and a prime-focus telescope tutorial to the documentation. Oct 12, 2024
@byrdie byrdie merged commit 0263951 into main Oct 12, 2024
11 checks passed
@byrdie byrdie deleted the docs/exposition branch October 12, 2024 21:11
@wtbarnes
Copy link

Sorry, was late weighing in. I think the added info on the landing page and especially the tutorial notebook help to give a lot of context as to how to use this. Thanks for adding that!

@byrdie
Copy link
Collaborator Author

byrdie commented Oct 12, 2024

No, I'm sorry for not giving you more time to review. Let me know if you notice anything and I'll fix it with a quick PR.

@wtbarnes
Copy link

No worries and will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants