-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve benchmarking reports #422
Merged
Ulthran
merged 14 commits into
main
from
421-improve-benchmarking-reports-to-include-relevant-info
Nov 10, 2023
Merged
Improve benchmarking reports #422
Ulthran
merged 14 commits into
main
from
421-improve-benchmarking-reports-to-include-relevant-info
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't seem like there's any perfect solution here, we could get all the info we want but double the DAG size, there doesn't appear to be any way to add custom scripts to execute after each rule. We should be able to get pretty darn good results with a script that runs at the end of the pipeline (maybe even perfect if the user's willing to run with |
Ulthran
deleted the
421-improve-benchmarking-reports-to-include-relevant-info
branch
November 10, 2023 05:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add input file sizes to benchmarking data collected
Deprecate --target_list option of sunbeam run
Fix config for filter_reads rule
pytest .tests/
on a local deployment and the tests passed successfully.tests/targets.txt
temp
If this is for a release:
snakedeploy pin-conda-envs workflow/envs/*.yml
)install.sh
to match what this release's version will bebash dev_scripts/generate_archive.sh
)