Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve benchmarking reports #422

Merged

Conversation

Ulthran
Copy link
Contributor

@Ulthran Ulthran commented Oct 25, 2023

Add input file sizes to benchmarking data collected
Deprecate --target_list option of sunbeam run
Fix config for filter_reads rule

  • I have run pytest .tests/ on a local deployment and the tests passed successfully
  • If this adds a new output file, I have added a check to .tests/targets.txt
  • If this fixes a bug, I have added or modified an appropriate test
  • If this adds or modifies a rule that uses FASTQ files, the input accepts gzipped FASTQ and outputs gzipped FASTQ, or marks uncompressed FASTQ output as temp

If this is for a release:

  • I have updated documentation
  • I have updated all conda pin files (snakedeploy pin-conda-envs workflow/envs/*.yml)
  • I have updated the hardcoded version at the top of install.sh to match what this release's version will be
  • I have created a release archive that will be attached to this release (bash dev_scripts/generate_archive.sh)

@Ulthran Ulthran linked an issue Oct 25, 2023 that may be closed by this pull request
@Ulthran
Copy link
Contributor Author

Ulthran commented Nov 6, 2023

Doesn't seem like there's any perfect solution here, we could get all the info we want but double the DAG size, there doesn't appear to be any way to add custom scripts to execute after each rule. We should be able to get pretty darn good results with a script that runs at the end of the pipeline (maybe even perfect if the user's willing to run with --notemp).

@Ulthran Ulthran merged commit facec83 into main Nov 10, 2023
2 checks passed
@Ulthran Ulthran deleted the 421-improve-benchmarking-reports-to-include-relevant-info branch November 10, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve benchmarking reports to include relevant info
1 participant